Code quality enhancement - Integrations::Discord::Service

Codeminer42 / cm42-central

Fork and Evolution of the Fulcrum project - An agile project planning tool and Pivotal Tracker drop-in replacement

https://central.cm42.io

GNU Affero General Public License v3.0

306 stars 74 forks source link

Code quality enhancement - Integrations::Discord::Service #959

Open wrspada02 opened 2 months ago

wrspada02 commented 2 months ago

APIs (#send and .send) are inconsistent, and the #send method includes an environment check (Rails.env.development?) and makes direct external HTTP requests, which should be encapsulated. Similar issues apply to Integrations::Slack::Service and Integrations::Mattermost::Service.