search

Codennnn / Green-Wall

⬜🟩 GitHub Contributions Graph Generator. :octocat:
https://green-wall.leoku.dev
MIT License
371 stars 12 forks source link

Share URL parameter displayName not being honored #16

Closed shrinathnayak07 closed 1 year ago

shrinathnayak07 commented 1 year ago

Issue

Share URL parameter displayName not being honored

Type

Bug

Description

When a share URL is generated with displayName=1, it means that the username displayed should be Github's name and not the username. But when we copy the generated link in a new tab, even if the displayName=1, we are still showing the username which is wrong

Solution

On the share page, along with size and theme, I have added displayName as it was missing. In the URL generation, we are using size, theme, and displayName

Use case validated

  1. By default, the username should be shown
  2. When the URL parameter has displayName=1, we need to display the name

Screenshots

Issue

Screenshot 2022-12-31 at 12 48 27 AM

Fix

Screenshot 2022-12-31 at 12 48 46 AM
vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @Codennnn on Vercel.

@Codennnn first needs to authorize it.

Codennnn commented 1 year ago

Thank you for fixing the bug and making GreenWall better!