search

CodepadME / laravel-tricks

The source code for the Laravel Tricks website
http://laravel-tricks.com
MIT License
967 stars 297 forks source link

Feature: Google Login #35

Open Remo opened 10 years ago

Remo commented 10 years ago

Right now, it's a bit confusing, when you want to comment, you can log in using your google account, but not using your github account while you can only use github to log in to create a trick.

If we'd support google in both places, one would at least not have to use two different accounts on one site...?

msurguy commented 10 years ago

Well, the commenting and the application are not using one system at the moment. Using Disqus enables us to take advantage of the free commenting platform instead of spending the time to build our own.

So even if we had Google login on the laravel-tricks website, it would in no way remove the need to login with disqus/google account for commenting.

We could add support of logging in with google for the site in general but is there really a need for that, since almost any developer has a Github account these days. Right?

Remo commented 10 years ago

I'm aware of the difference in those two systems and no, it wouldn't be a single sign on concept. It's just that I received several messages from people who were confused. Using one login twice seems to be less confusing than using two logins.

It's certainly not a big deal and to me who's using the site once a week, it's pretty clear, it's just that newbies don't understand the difference.

I'm not sure there's even a really "nice" solution to this as long as disqus doesn't provide us with some kind of single sign on solution where you'd be logged in in both systems.

Remo commented 10 years ago

Having just posted that, it seems like there's some kind of disqus SSO http://help.disqus.com/customer/portal/articles/236206-integrating-single-sign-on I've never saw that before, what about you? Any reason not to look into this?

msurguy commented 10 years ago

Thank you, that looks interesting.

I would love to see how this could work together. @Remo, Is there a chance you could test this somehow and see if this works as expected?

I've dug up the PHP example script: https://github.com/disqus/DISQUS-API-Recipes/blob/master/sso/php/sso.php

If you could implement that on a separate installation and see if it works, I would really appreciate it. What do you think?

Remo commented 10 years ago

I'll try to have a closer look at this, not sure if that script really does what we need though. I'll let you know once I've had a closer look, could take a while though!

msurguy commented 10 years ago

Take your time, @Remo. Thank you!