search

CodepadME / laravel-tricks

The source code for the Laravel Tricks website
http://laravel-tricks.com
MIT License
966 stars 298 forks source link

strings moved to "lang" #50

Closed Remo closed 10 years ago

Remo commented 10 years ago

As mentioned here https://github.com/CodepadME/laravel-tricks/issues/11, it would be great to have all strings in one place.

This pull request is incomplete, but before I spend more time on this, would you guys merge something like this? Anything I'd have to change? (I'm just trying to make sure I can update my concrete5recipes sites)

jumilla commented 10 years ago

lang/en/admin.php is missing?

Remo commented 10 years ago

@jumilla yes, @msurguy was a bit too quick, I'm still working on it, only wanted to know if my approach is okay ;-) Here's the missing file https://github.com/CodepadME/laravel-tricks/pull/53 but I'll work on this today, more to come

jumilla commented 10 years ago

@Remo We are doing the work of translation into Japanese in jumilla/laravel-tricks now. Since it was special, your work was taken in.

Our approach makes the directory directly under a views directory one translation file. For example, it is put on lang//home.php by the localization strings of views/home/.blade.php.

Work is due to be finished to about one week. I hope I can tackle work in cooperation.

Remo commented 10 years ago

@jumilla good to hear! I didn't create a file per view but only a file per view directory. Thought we'd have too much redundancy, but I'm open to change it if there's a good reason.

I've updated my other PR https://github.com/CodepadME/laravel-tricks/pull/53