search

Coder-Spirit / Jupyter-PHP-Installer

An installer for Jupyter-PHP
MIT License
43 stars 20 forks source link

Added support for Windows #14

Closed bstoney closed 7 years ago

bstoney commented 7 years ago

Updated WindowsSystem and WindowsInstall to support Windows install, converted from UnixSystem and UnixInstall

castarco commented 7 years ago

There are some points that should be improved (like the usage of string literals instead of referencing Window's environment variables)... but I'll merge this PR and later polish these points.

bstoney commented 7 years ago

Thanks for the feedback. I did consider adding in at least the APPDATA and PROGRAMDATA variables, but ran out of time. I'll have another look at it while I'm still looking at the Jupyter-PHP kernel.