Coder-Spirit / php-bignumbers

A robust library to handle immutable big numbers inside PHP applications
MIT License
131 stars 29 forks source link

Default value for $scale should not be null (arccos, arctan, arcsec, arccsc, tan, cotan etc.) #68

Open gregor-tb opened 5 years ago

gregor-tb commented 5 years ago

public function arccos(int $scale = null): Decimal

$scale is null here by default, but used like (int) 0. This is working in the additions $scale + 2 etc., but crashes on calling round(int) method, which does not accept null.

But later it is checked for explicit null value

$scale = ($scale === null) ? 32 : $scale;