CircleCi script should differenciate test from deployment build

CoderDojo / community-platform

Zen, the CoderDojo Community Platform!

https://zen.coderdojo.com

MIT License

121 stars 55 forks source link

CircleCi script should differenciate test from deployment build #1100

Open Wardormeur opened 7 years ago

Wardormeur commented 7 years ago

Right now, CircleCI deploys the same version of the env than the one for test, which means it contains every dev-dep, slowing down our deployment by quite a bit (current node_module for cp-zen is 300+ Mb) We need to differenciate a PRE-merge build which goal is to test the PR, from a merge build which is aimed at being deployed.

Wardormeur commented 7 years ago

Seems like the solution are either :

use a different branch to check the PR (dev) and push to master when merged
eventually check if one of those env variable is available and script some stuff behind https://circleci.com/docs/environment-variables/#build-details (IE : CI_PULL_REQUEST should probably be not defined when merging? cf https://discuss.circleci.com/t/running-specific-tests-only-on-a-pull-request/500)

Wardormeur commented 6 years ago

@DanielBrierton is this still the case ?