search

CoderDojo / community-platform

Zen, the CoderDojo Community Platform!
https://zen.coderdojo.com
MIT License
121 stars 55 forks source link

New users prompted to complete profile even though there's no new info required #1114

Open DanielBrierton opened 7 years ago

DanielBrierton commented 7 years ago

This is because "alias" is a required field, but not asked for during registration, and, here's the kicker, isn't even a field you can fill out as an adult! 😅 But thankfully(?) _.keys doesn't care that alias is null, it will still consider alias to be a key, so after saving your profile with the exact same data, you're good to go! 👍

Wardormeur commented 7 years ago

@DanielBrierton keep it open for a proper fix ? @rosalanghammer do we still need this "profileCompleted" boolean? Most if not "all" data has been asked through the registration process to my knowledge

rosalanghammer commented 7 years ago

No need for this logic if all required fields are filled out. Don't know why this was added historically and assume will be taken into consideration in new registration process.

On 12 May 2017 at 11:50, Wardormeur notifications@github.com wrote:

@DanielBrierton https://github.com/danielbrierton keep it open for a proper fix ? @rosalanghammer https://github.com/rosalanghammer do we still need this "profileCompleted" boolean? Most if not "all" data has been asked through the registration process to my knowledge

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CoderDojo/community-platform/issues/1114#issuecomment-301098090, or mute the thread https://github.com/notifications/unsubscribe-auth/AMO7IP1mBC04qEJ1xZSWb2gLPRTxv3T2ks5r5HHFgaJpZM4K4VC8 .

-- Rosa Langhammer Reporting Lead @ CoderDojo Foundation +353 872686 <+353+851088135>779 | @RosaLanghammer | Skype: rosa.langhammer l https://mail.google.com/mail/u/0/#UNIQUE_ID_SafeHtmlFilter_ Github: rosalanghammer

I'm currently working on UTC-3 from Santiago, Chile. Check out where I am in the world next month here >> https://coderdojo.com/news/2016/05/20/dojo-tour-the-coderdojo-foundation-on-the-road/

-- This month we are rewarding and recognising https://coderdojo.com/news/2017/05/02/12874/ the efforts of youths and volunteers across the CoderDojo community! https://coderdojo.com/news/2017/05/02/12874/

-- Hello World Foundation operating as the CoderDojo Foundation is a company limited by guarantee not having a share capital with charitable status, CHY

  1. Registered in Dublin, Ireland, No 524255. Registered Office: Dogpatch Labs, Unit 1, CHQ Building, Custom House Quay, Dublin 1, Ireland.