CoderDojo / community-platform

Zen, the CoderDojo Community Platform!
https://zen.coderdojo.com
MIT License
121 stars 55 forks source link

Language drop down does not have the current language selected by default #1115

Closed DanielBrierton closed 6 years ago

DanielBrierton commented 7 years ago

This means, as a result, you cannot switch from another language to English, since a change needs to occur in the selected value in order to trigger the language change

asonder commented 7 years ago

I'd like to take a shot at this issue. This is my first time contributing to open source, and I'm excited to get involved.

Wardormeur commented 7 years ago

Do you have the stack installed yet? If not, have a look at https://github.com/CoderDojo/cp-local-development . For the next steps, I believe @DanielBrierton is having a better understanding of how it works than I do 😅

asonder commented 7 years ago

Thanks for the info. I'm going to install the dev environment today, and when I'm working on the bug I'll check with @DanielBrierton if I have questions.

DanielBrierton commented 7 years ago

@asonder Thanks for taking this, great to hear your stepping into the world of contributing to open source. 😄 If you have any issues getting set up, or on the bug itself, you can grab me on our Gitter: https://gitter.im/CoderDojo/community-platform or we can continue discussion here on this issue.

asonder commented 7 years ago

Thanks @DanielBrierton ! I started to set things up yesterday, and I hope to have it done by the end of the week so that I can start working on the bug. I'll reach out if I have any issues.

asonder commented 7 years ago

@DanielBrierton just letting you know that installing the dev environment is taking a little longer than expected, but I'm still committed to working on this bug!

Wardormeur commented 7 years ago

@DanielBrierton @dmitry-portnoy gave it a try but couldn't reproduce Hints? Could it has been a side effect of the double cookie issue we had previously

Wardormeur commented 7 years ago

@DanielBrierton up !

Wardormeur commented 6 years ago

Cannot reproduce anymore, either on old or new front-end. Closing off!