CoderDojo / community-platform

Zen, the CoderDojo Community Platform!
https://zen.coderdojo.com
MIT License
121 stars 55 forks source link

I have read and accept the Terms and Conditions here - no link #1118

Closed niccokunzmann closed 7 years ago

niccokunzmann commented 7 years ago

When I visit the German registration site, I see no link to the terms and conditions. I believe it could be due to the key used here which is not the same as in the messages.po file. @rhemon - what do you think?

rhemon commented 7 years ago

I am not sure why its doing that, since locally for the msgid I changed msgstr to things and added the same anchor tag, and things worked fine

niccokunzmann commented 7 years ago

So, I do not understand why we still have this text:

capture

Here: https://zen.coderdojo.com/register/user And without Link, if the changes go live automatically.

butlerx commented 7 years ago

this appears to be an issue with the translation on crowdin https://crowdin.com/translate/zen-community-platform/1/en-de#q=next

niccokunzmann commented 7 years ago

Can we re-open the issue until the translation shows up correctly?

Wardormeur commented 7 years ago

Even in english, the link doesn't show up. It may be an issue w/ i18n not supporting HTML @DanielBrierton Edit : Cache issue ~~

Wardormeur commented 7 years ago

It seems to work for Deutsch, can you confirm @niccokunzmann ? (It's not translated though, still in English)

niccokunzmann commented 7 years ago

It supports HTML: https://zen.coderdojo.com/terms-and-conditions search for creative commons.

niccokunzmann commented 7 years ago

Confirmed. It works in German, now. It was not as I was looking at it. https://zen.coderdojo.com/register/user I will see. I believe, I translated it but maybe crowdin did not build... looking into it.

Wardormeur commented 7 years ago

Probably the same issue than i had, browser cache :)

niccokunzmann commented 7 years ago

In crowdin it is translated: https://crowdin.com/translate/zen-community-platform/1/en-de#5723 Crowdin did not build after I translated it: https://crowdin.com/project/zen-community-platform/de/activity I do not know: Is a "crowdin build" required for the translations to go live?

niccokunzmann commented 7 years ago

Let us see if the translation is live and in German and then, I will close the issue.

butlerx commented 7 years ago

crowdin is only built on deployment from circle so it is built and the text updated each time a pr is merged to master

DanielBrierton commented 7 years ago

To add to @butlerx's response, there is also the added complication of crowdin builds being rate limited, I believe to once every 30 mins. So, if two builds happen 20 mins apart and a translation is updated in between them, there's the potential for it to not get into the second build. You can be sure however that it will get into a future build, and we build fairly regularly.

niccokunzmann commented 7 years ago

Thank you all, this issue is resolved! @rhemon https://zen.coderdojo.com/register/user is German, now too.

Wardormeur commented 7 years ago

Don't forget to tick it on #934 :D