search

CoderDojo / community-platform

Zen, the CoderDojo Community Platform!
https://zen.coderdojo.com
MIT License
121 stars 55 forks source link

Replace mailtrap by maildev #1143

Closed Wardormeur closed 6 years ago

Wardormeur commented 7 years ago

In order to avoid rate limits of mailtrap, we should replace mailtrap by any nodejs based mail (ie maildev) It should be included by cp-local so that the production stack is not impacted

Wardormeur commented 6 years ago

@butlerx complexity-wise, could cp-local spin up a maildev server ?

butlerx commented 6 years ago

that's relatively simple adding a mail server container wouldn't take much. Would we want it to actually send an email or just to kill all mail?

Wardormeur commented 6 years ago

replace mailtrap :) So the config for localhost config should change to use maildev instead

butlerx commented 6 years ago

sorry i misunderstood. adding maildev should be super quick as it already has a container. so in the docker-compose we can just add this and modify all the mailtrap references in the configs to maildev container

Wardormeur commented 6 years ago

@heyitsmaimai handled that without much issues :) https://github.com/CoderDojo/cp-local-development/commit/caa8eb64e8ea46e1e67174daac386df6cd2d047b