Ensure all JS files are linted and checked during build

CoderDojo / community-platform

Zen, the CoderDojo Community Platform!

https://zen.coderdojo.com

MIT License

121 stars 55 forks source link

Ensure all JS files are linted and checked during build #1163

Closed DanielBrierton closed 6 years ago

DanielBrierton commented 7 years ago

My preference would be for all code, front-end and back-end, to be compliant with semistandard. I'm open to debate on this though. /cc @Wardormeur

Currently a mix of semistandard and jshint is used, with some files not being covered by the linter at all, making code styles inconsistent across the repos.

Wardormeur commented 6 years ago

This is a WIP. Choice is a custom config based on airbnb Covered :

[ X ] cp-zen-frontend

butlerx commented 6 years ago

this is done for cp-orgs and #1189 will cover this for cp-platfrom

butlerx commented 6 years ago

[ ] cp-badges-service
[ ] cp-dojos-service
[ ] cp-eventbrite-service
[ ] cp-events-service
[x] cp-organisations-service
[ ] cp-users-service
[x] cp-zen-frontend
[ ] cp-zen-platform

Wardormeur commented 6 years ago

closing off, has be done during the node 8 upgrade