CoderDojo / community-platform

Zen, the CoderDojo Community Platform!
https://zen.coderdojo.com
MIT License
121 stars 55 forks source link

Lock DoB for non-cdf users #1175

Open DanielBrierton opened 7 years ago

DanielBrierton commented 7 years ago

A number of users have signed up with their child's date of birth, which is causing issues when they try do actions intended for adults, like start a dojo, or add child.

These users have generally updated their profile with their own details, but their user type stays as attendee-o13. We should change the user's user type according to the date of birth entered when updating their profile.

Wardormeur commented 7 years ago

No. DoB should be un-editable by non cdf to avoid bypass of restrictions. I understand that it's problematic right now, but the solution is to fix the reg flow to avoid mistakes and to provide admin tools to change it more easily. Letting an user change is DoB and his usertype i slike removing any restriction you have on any flow :) @rosalanghammer

rosalanghammer commented 7 years ago

Issue is not about user being able to change DOB (this should be locked), but if CDF Admin update DoB then the usertype should update.

Agree that a better flow should negate a lot of these issues but this needs to be done to allow past users profiles to be updated.

DanielBrierton commented 7 years ago

The outcomes of this: