search

CoderDojo / community-platform

Zen, the CoderDojo Community Platform!
https://zen.coderdojo.com
MIT License
121 stars 55 forks source link

Dojo emails should be using dojo language #1198

Open Wardormeur opened 7 years ago

Wardormeur commented 7 years ago

Depends on https://github.com/CoderDojo/community-platform/issues/989, emails coming from the dojo should be translated in the language of the dojo. This include emails to the dojo Email (automated emails like join notification) as well as email to the users of the dojo (custom emails, automated emails ( ticketing))

niccokunzmann commented 6 years ago

(1) Shouldn't they use the language of the user reading the email?

(2) With your templates, you have the ability, to provide a link at the top like this:

http://zen.coderdojo.com/template/text.html?lang=en&username=John%20Doe

This would allow to render most templates in all languages. The link can be provided at the top: "View in Webbrowser/Translations" Allowing a menu for languages and a link to the crowdin if they would like to translate a template.

Wardormeur commented 6 years ago

1) We could, but it means to ask one more configuration from the user, while a configuration at a dojo level would impact more easily than "each" user having set their locale. Ultimately it would be per user and if it's not set, the dojo's language, but we can assume that they speak the same language in a dojo, and hence have a quicker impact/result.

2) We plan to work on tests for translations and it requires us to create those "mock" data for templates. Once we have those, exposing a rendered version should be totally doable. Not sure though if it'll allow "in-context" translation as the variable will already be rendered. I think another issue for this would be nice so we can set up the steps to make it work.