search

CoderDojo / community-platform

Zen, the CoderDojo Community Platform!
https://zen.coderdojo.com
MIT License
121 stars 55 forks source link

Notify All Members on Event page sends a generic email #1205

Closed owencutajar closed 7 years ago

owencutajar commented 7 years ago

The UI on 'Notify All Members' asks an admin to pick an event to notify users about. However, the email that is sent is a generic invitation to 'Next Event'. This would be more useful if it refered to the selected event and directed users to the specific event page.

all-self-taught commented 7 years ago

See pull request #341 and #9, it's done in cp-dojos-service and cp-translations.

Wardormeur commented 7 years ago

We can't use the hashtag cross-repos ;) https://github.com/CoderDojo/cp-translations/pull/9 and https://github.com/CoderDojo/cp-dojos-service/pull/341 for future review

Wardormeur commented 7 years ago

Just a small change to be done on cp-dojos, elsewhat it works, thanks @all-self-taught :)

all-self-taught commented 7 years ago

Small change is complete. Exposes only event name in code.

Wardormeur commented 7 years ago

I modified a bit your translations as the phrasing differed between some email. Elsewhat, it's merged, thanks for your help @all-self-taught and @owencutajar for reporting this improvement :+1: