search

CoderDojo / community-platform

Zen, the CoderDojo Community Platform!
https://zen.coderdojo.com
MIT License
121 stars 55 forks source link

Sending an email to a large quantity of users is slow #1219

Closed Wardormeur closed 6 years ago

Wardormeur commented 6 years ago

The lack of queing and usage of synchronous sending of email, can result in a seneca timeout and a (falsy) error message -> while it works locally without timeout, I expect production to be slower and reach the timeout easily -> See https://github.com/CoderDojo/cp-dojos-service/blob/master/lib/dojos/users/notify.js#L84

Wardormeur commented 6 years ago

This has been done recently thanks to @butlerx PR (https://github.com/CoderDojo/cp-dojos-service/commit/df42384c35dc594df7f85a98cde4553e952675c4)