CoderDojo / community-platform

Zen, the CoderDojo Community Platform!
https://zen.coderdojo.com
MIT License
121 stars 55 forks source link

Allow CDF admins to delete users #1235

Closed Wardormeur closed 5 years ago

Wardormeur commented 5 years ago

The goal is to allow soft and hard delete by CDF admins of users accounts, as well as any related data (profiles and children profiles, applications, memberships). Soft delete should be used for deletion request in order to keep the statistical data, while hard delete should be used for any duplicate account, test account or bugged accounts.

Wardormeur commented 5 years ago

Update Middleware : https://github.com/CoderDojo/cp-zen-platform/pull/1333 Frontend: https://github.com/CoderDojo/cp-zen-frontend/pull/236 Club-service: https://github.com/CoderDojo/clubs-service Users-service: https://github.com/CoderDojo/users-service Events-service: https://github.com/CoderDojo/events-service/pull/25 TBD : cp-local-development to automatically install those new services

Clubs-service and Users-service are copies of events-service : it might contain crust of unused files, or strategy I don't want to use anymore (the automatic pre-setting of the queryBuilder is something I find dodgy to control, for example, without simplifying the code: exposing as an util could be better). I don't mind much as long as the API is doing what's expected : deleting and applying the right params, but is of course open to comment on making it cleaner.

Wardormeur commented 5 years ago

cp-local-development: https://github.com/CoderDojo/cp-local-development/pull/79

Wardormeur commented 5 years ago

Closing, all PRs have been merged. Process will be monitored in the next weeks to look for any specific issues