Birthday prompt not working correctly

[conoramurphy-zz]

Background On the CoderDojo dashboard there is an alert that appears a few months before the dojos yearly anniversary inviting them to apply for a birthday pack. There have been some reports of edge case behaviour that it would be good if we could cleanup here.

Few reports of odd birthday prompt behaviour

• Reports of birthday prompt appearing for people who have an unverified test dojo
• Reports of people who are champion to 5/6 dojos (Belgium for example) have a stack of about 10+ alerts clogging up the dashboard

If we can recheck the logic to make sure it's only verified, active dojos and only show 1 per champion.

[Wardormeur]

1- Tehre is an edge case on unverified Dojo. Yes, they will show up as we load the Dojo from the relationship of the user (https://github.com/CoderDojo/cp-zen-frontend/blob/ec65be3e3aa5de44a7b44370cfab86a48eea9319/src/dashboard/cd-dashboard-events.vue#L138). However, it means the person has 10 months old unverified Dojo. (https://github.com/CoderDojo/cp-zen-frontend/blob/ec65be3e3aa5de44a7b44370cfab86a48eea9319/src/dashboard/cd-dashboard-dojo-anniversary.vue#L46). Filtering it up to ensure it's verified is a probable solution, but defo an edge case. 2 - The clogging was accepted at the time. Removing it will degrade the message to something generic and could be assumed to be per Champion, rather than per Dojo. That will also remove the possibility to backfill information into the form. A solution would be to handle single Dojo and multiple Dojos anniversaries differently, to avoid that situation; if we really want to go that way and avoid that lose of formatting. Also it saves the current translation.