Closed dberesford closed 9 years ago
If you guys want I can put issues into separate smaller Github issues in the future - whatever works best for you.
Hi @tangentfairy, I've just added some of my comments in bold above, thanks!
That's great thank you!
The day/month/year fields on the second step seem to be blank when I first get to the registration step. They show up on a page refresh.
The Registration button is still not working for me. This is after a full page refresh.
@tangentfairy ok it could be a validation issue, are you filling in all of the required fields? I'll check it out anyway :)
Yes I filled out all the fields and I don't see any validation errors. There is a POST to save_dojo_lead being executed. The response is a 502.
I'm wondering if it's an issue with the server, it seems to take some time to load the site. I'll have a look anyway :)
@tangentfairy I've deployed the latest changes to the server now, the champion registration should work :)
Works now, thanks a million!
Assigning to @ckiss, can you please close this when you fix CoderDojo/cp-zen-platform#96
https://github.com/CoderDojo/cp-zen-platform/issues/96 has been closed. I'll close this too.
Feedback email from @tangentfairy and the team:
Here's some feedback from myself, the main issue being that at the moment I cannot get past the "Champion Registration" step. I know it was working last week so something must have changed.
1) I cannot input email address and full name. Form doesn't allow me. See screenshot. This works if I refresh the page, then those fields are prefilled with what I entered on the previous page. - Fixed
I cannot select a country on this page either. It works if I refresh too. Laura says it does not work for her on refresh. - Fixed
2) The loading of the page looks very odd when I refresh. If I have already gotten to step 2, it appears to load step 1 and then redirect and load step 2. Can we make it just appear to load step 2? - Fixed
3) The date of birth field looks great with the calendar, but if I am on City/Town, I fill out City/Town and then I tab to the next field, the calendar doesn't come up. Can we change this so the calendar comes up when you tab to the to Date of Birth field?
4) If I enter a town that doesn't exist in the geocoder, E.g. "Catania" in "Italy" - then it blanks out my entry when I go to another text field. Are we allowed to enter a dojo that isn't geocoded? If it doesn't show up can we have a map show up to pinpoint the town?
It seems really difficult to understand that you need to pick an option from the list for the city/town field. If I typed in "Enniscorthy" and then didn't select "Enniscorthy, Loch Garman, Leinster", then how do I know I have to select that option? we need to fix the validation here, the place field is required but it's not working properly
Would like to know what Eugene thinks about those points.
5) City/Town lookup is case sensitive - can we capitalize the word and do the lookup OR lowercase lookups being returned? I don't expect the user to capitalize it themselves.
6) Date of birth field is automatically set to the current date. Can we set it to at least 18 years ago.
7) Register button doesn't work. I see an ajax call to save_dojo_lead but the form doesn't go to the next page. Tried this in Chrome and Firefox. - Fixed
Rosa did get to look at it last week so her feedback includes the steps past Champion Registration. I'll provide more feedback when it is fixed.
Here's a list of feedback from Rosa: