CoderDojo / community-platform

Zen, the CoderDojo Community Platform!
https://zen.coderdojo.com
MIT License
121 stars 55 forks source link

Existing dojos do not generate coordinates #55

Closed tangentfairy-zz closed 9 years ago

tangentfairy-zz commented 9 years ago

I tried inputting the locations of two existing dojos but I don't get any results. This is on the staging server.

This is related to what I was saying about possible "edge case" coordinates - but it seems like these existing dojos should still work. Both areas are easily found on Google maps.

First, our existing dojo in Argentina:

Then I tried an existing dojo in Japan The location is a large area in Google Maps so I'm not sure why we can't geocode it. ![google-maps-tokyo](https://cloud.githubusercontent.com/assets/1136491/7562001/8c6e455a-f7c8-11e4-85a0-29e66370ab29.png)
iantocristian commented 9 years ago

@tangentfairy if you are asking why the city/town box can't find certain places, the answer is that we've only imported / indexed geonames data for a few countries: Ireland, United Kingdom, Germany, Romania, I think that's it

iantocristian commented 9 years ago

on the staging server that is

tangentfairy-zz commented 9 years ago

Okay cool - how long would it take or how easy would it be to do the other countries?

iantocristian commented 9 years ago

As we have it right now geonames-import has to be called separately for every country that you want to import, but we'll look into adding an --all flag to enable all countries to be imported in a single run. It will take a while for the script to complete running with that flag enabled and get geonames data indexed for all countries, not sure how long though - a couple hours I'd say.

tangentfairy-zz commented 9 years ago

It would be good to do this before going live anyway, just to make sure the current dojos with unusual addresses work - it's not a priority for now.

ckiss commented 9 years ago

This has been implemented. You have to run scripts/geonames-import.js --country=all