CoderDojo / community-platform

Zen, the CoderDojo Community Platform!
https://zen.coderdojo.com
MIT License
121 stars 55 forks source link

Privacy statement page #60

Closed tangentfairy-zz closed 8 years ago

tangentfairy-zz commented 9 years ago

In addition to the cookie banner, we'll need a page listing all of the cookies we'll be using on the site, as per regulations.

We can fit this in as part of the privacy statement Rosa is drafting

Will assign myself this one for now.

tangentfairy-zz commented 9 years ago

I have the statement to send on to anyone who can put this in - we can just have a link in the footer to it

gisellegk commented 8 years ago

Hi! I'm participating in 24 Pull Requests and I started a day late! This will be my first time contributing to something open source...

How can I help with this issue? I'm not sure what file I should be looking at....

tangentfairy-zz commented 8 years ago

Hi @gisellegk - thanks for offering to help out! The readme has some information about the project and how to get set up with local development. You'll only need to put in a request to the frontend repository for this task.

The link to the page could go in the footer here and the way the charter page is set up would be a good example (the charter itself is here).

All text needs to be added to the translations file, and in the templates we use an i18n plugin.

The privacy statement itself is in a public Google Document here - and I am presently adding the cookies list to it. The most tedious part of this will be using a different i18n key for each section, as we ideally don't want HTML elements getting into the messages.po file.

Let me know if you have any questions - and if you want to join the Slack :) - I'm on the 24 Pull Requests gitter.im also!

gisellegk commented 8 years ago

@tangentfairy I'm on it! Thanks!

gisellegk commented 8 years ago

So I had an issue installing the node packages because of my school's internet filter :(

I won't make it for today's 24 pull request but now that I'm home and am all set up I'll try for tomorrow!

tangentfairy-zz commented 8 years ago

Cool! Mail me at ursula@coderdojo.org if you have any problems - would be interested to hear what was blocked by the internet filter also.

gisellegk commented 8 years ago

It was whatever Phantom.js' package is hosted on... kept timing out and I tried to download it manually and it came up as the filter page. npm install-ing worked perfectly on unfiltered home wifi though :)

tangentfairy-zz commented 8 years ago

Great! :)

gisellegk commented 8 years ago

So when I run ./start.sh development ./service.js I get this error message:

config file not found: development
Usage: ./start.sh <config> <startscript> [startscript_opts]...

There also is no scripts/insert-test-users.js to run.... Am I missing a step somewhere..? Also should I be emailing these kind of questions to you, or commenting here?

tangentfairy-zz commented 8 years ago

You don't need to run this - make sure you are following the instructions in this repository: https://github.com/CoderDojo/cp-local-development Once you have installed the perquisites you will be able to run the init and run commands.

The cp-zen-platform repo is just the front end part of the system. I'm going to update the readmes of the other repositories to point to cp-local-development now to avoid any further confusion - I can understand why this happened! :)

gisellegk commented 8 years ago

@tangentfairy Took a break from working on this but I'm back.

Still stuck on setting up everything...

It keeps telling me createuser: could not connect to database postgres: FATAL: role "giselle" does not exist Am I in the wrong directory?

josmas commented 8 years ago

Hi @gisellegk It looks like you are trying to connect to the DB directly with your user. Have you created a 'platform' user as explained here?

If you can provide a step by step description of what you've done so far for the local install, we might be able to help out.

gisellegk commented 8 years ago

@josmas so I already have node, git, and grunt installed. I then installed PostgreSQL (sudo apt-get install postgresql) and pgAdminIII (sudo apt-get install pgadmin3).

Then, I ran createuser -P -s -e platform and it prompts me for the password twice, which I type, then it gives me the error I mentioned above.

I'm in the cp-zen-platform directory for all of this btw. It didn't mention having to clone any particular directory for this until the Code Setup section so I guessed that it didn't matter.

josmas commented 8 years ago

Hi @gisellegk thanks for that. Try creating the new user with the _postgres_ admin user, like: createuser -U postgres -P -s -e platform

before that can work, make sure that you can use the _postgres_ user. The trust method for the admin user may be good enough if you are running this only locally. If you want to play safer, then you can add a password to it.

You are correct guessing that so far it does not matter which particular directory you do this from (so far it's just a postgresql issue).

niccokunzmann commented 8 years ago

Hi @gisellegk if you like to try it out: I created automated installation methods at cp-docker-development. There are scripts to install it under Ubuntu, to use docker and just to use a VM. If you like to try it out, please report/change any thing you like. Maybe you want to look at the differences you have to the ubuntu.sh installation. I would be happy if you use it. It was created to fast setup the cp-local-development repository.

gisellegk commented 8 years ago

@niccokunzmann I tried your script file... It keeps getting stuck on this:

Remove the following npm installations: /usr/local/bin/npm done?

I tried deleting that file (and now it's gone) but it's still giving me the same message so I'm not sure what to do...

niccokunzmann commented 8 years ago

I think you can uninstall this with sudo apt-get remove OR you edit the script and remove the installation of npm. Maybe you just type ENTER and it runs further. I followed the tutorial at cp-local-development. This is why it says that it wants it to be removed. You can edit the file as you like, if that helps.

gisellegk commented 8 years ago

I just edited the script... looks like I am on my way. Thanks so much!

niccokunzmann commented 8 years ago

Please let me know what you edited, maybe upload it or give it to me, so I can improve the existing script.

gisellegk commented 8 years ago

@niccokunzmann I just deleted the node installation part, so not a super useful edit.... I'm not good with shell scripts, so I don't know how to do it myself, but maybe giving the option to skip over instead of only asking to delete the previous installation would be helpful?

niccokunzmann commented 8 years ago

@gisellegk Is it running on your platform?

gisellegk commented 8 years ago

@niccokunzmann yes, it does! A couple days ago it randomly stopped working but I think it was an unrelated issue... but now it's working fine.

Also, a couple of general questions: ( @tangentfairy ?)

  1. Does this page need to have the user confirmation stuff like the Charter? right now I based it off of the Terms and Conditions page -- text only...
  2. Where is a good place to put css to style the cookies table?
tangentfairy-zz commented 8 years ago

@gisellegk

  1. Text only is fine for now!
  2. The main css file is here. I think there's a table-striped class in bootstrap that makes tables look quite good! It is used in the events section somewhere.

Let me know if you need anything else, and thanks for taking this on!

gisellegk commented 8 years ago

I just put in the pull request. Thank you all for being so patient and supportive of me!

tangentfairy-zz commented 8 years ago

This is live now, thanks so much @gisellegk! If you'd like to join the CoderDojo Foundation Slack channel for development chat, send me a mail on ursula@coderdojo.org

I've invited you to become a member of this organization now too :)

niccokunzmann commented 8 years ago

Are there existing translations of the text one could refer to during translation?

tangentfairy-zz commented 8 years ago

@niccokunzmann - The Google doc with the text is here. It is available for translation in CrowdIn now that this issue has been closed!