search

CoderDojoGitHub / our-dojo

Our dojo's website, used for archiving lesson plans and signing up students for classes
http://coderdojosf.com
5 stars 4 forks source link

Refactor stylesheets #40

Closed mikefowler closed 10 years ago

mikefowler commented 10 years ago

Refactored stylesheets and view markup for maintainability and to remove use of BassCSS stylesheet. Also implemented responsive styles.

mikefowler commented 10 years ago

@jonmagic seems like a big commit, but it's almost exclusively limited to stylesheet and view changes.

jonmagic commented 10 years ago

Sweet! I'll pull this down tonight and kick the tires.

jonmagic commented 10 years ago

The form on the home page:

coderdojo - san francisco-4

Looks a bit different than the forms on the event page:

coderdojo - san francisco-5

coderdojo - san francisco-6

jonmagic commented 10 years ago

Looks great :+1: Everything feels more consistent. I do have one question about the class names, I've never seen the pattern of using double underscore __ before, where does that come from?

mikefowler commented 10 years ago

@jonmagic: The class naming convention is BEM notation. Mostly just a habit for me at this point, it really helps me think about and read CSS in a more object-oriented way.

I'll make those forms more consistent (good catch) and update the PR.

mikefowler commented 10 years ago

@jonmagic, go ahead and merge if everything looks cool with that additional commit. :ship: