CoderLine / alphaTab

alphaTab is a cross platform music notation and guitar tablature rendering library.
http://www.alphatab.net
Mozilla Public License 2.0
1.27k stars 202 forks source link

Wrong rendering on only-tab mode #151

Closed j4kim closed 7 years ago

j4kim commented 7 years ago

Your environment

Expected Results

For this score, here is what MuseScore outputs in complete tab mode:

Smoke on the water tab rendered by MuseScore

Observed Results

Same score rendered by AlphaTab:

Smoke on the water tab rendered by MuseScore

I observe at least 3 problems:

Steps to Reproduce (for bugs)

Initialise AlphaTab with these options:

$('#alphaTab').alphaTab(
    staves: { id: 'tab', additionalSettings: { 'rhythm': true } }
);

(Like in the Guitar Tabs sample, which is not working in the online demo, by the way)

Danielku15 commented 7 years ago

Good finding. I haven't used the tab-only display a lot so I missed various details. In the latest commits I added several improvements to the tab-only rendering:

I compared the alphaTab output with the Guitar Pro rendering and beside some minor alignment differences it should show the features correctly now.

Is there anything else you spotted already?

j4kim commented 7 years ago

Great ! You definitely are a very efficient developer. I'll let you know if I observe other display errors.

Just in case you didn't notice it, the two first examples under the "Guitar Tabs" tab are missing in the online feature samples. It seems like the files/features/Rhythm.gp5 file is missing.