fix(webpack): Use webpack instance passed to plugin - Githubissues

CoderLine / alphaTab

alphaTab is a cross platform music notation and guitar tablature rendering library.

http://www.alphatab.net

Mozilla Public License 2.0

1.2k stars 198 forks source link

fix(webpack): Use webpack instance passed to plugin #1539

Closed Danielku15 closed 1 month ago

Danielku15 commented 1 month ago

Issues

Fixes #1523 Fixes https://github.com/CoderLine/alphaTab/discussions/1522

Proposed changes

Reorganizes the WebPack plugin to fix and improve following parts:

Use the WebPack provided to the plugin instead of importing it. This ensures allows usage in environments like nextjs where WebPack is hidden from the user and not shipped as NPM package.
We use the officially exposed APIs only and don't need to access internals through paths.
The detection of entry points in the webpack runtime plugin is now using some prefix to survive recompilation when the main files are not touched.

Checklist

[x] I consent that this change becomes part of alphaTab under it's current or any future open source license
[x] Changes are implemented
[x] Existing builds tests pass
[ ] New tests were added

Further details

[ ] This is a breaking change
[ ] This change will require update of the documentation/website