search

CoderPat / structured-neural-summarization

A repository with the code for the paper with the same title
MIT License
74 stars 26 forks source link

Potential typo in the instructions in the README #1

Closed ioana-blue closed 5 years ago

ioana-blue commented 5 years ago

First, thanks for sharing the code, saved me quite a bit of sweat :)

Second, there might be a typo in the instructions to build the vocabulary files. I'm (wild)guessing that the following lines should refer to the target file (instead of inputs):

ognn-build-vocab --with_sequence_tokens \
                 --save_vocab /data/naturallanguage/cnn_dailymail/output.vocab \
                 /data/naturallanguage/cnn_dailymail/split/train/inputs.jsonl.gz

should read

ognn-build-vocab --with_sequence_tokens \
                 --save_vocab /data/naturallanguage/cnn_dailymail/output.vocab \
                 /data/naturallanguage/cnn_dailymail/split/train/targets.jsonl.gz

if I understand correctly what this vocab file is meant for.

CoderPat commented 5 years ago

Thanks for this. Should be fixed