search

CoderPat / structured-neural-summarization

A repository with the code for the paper with the same title
MIT License
74 stars 26 forks source link

Documentation on requirements #2

Closed ioana-blue closed 5 years ago

ioana-blue commented 5 years ago

It would be nice if the readme included a couple of lines on requirements, specially the tensorflow version that this code was ran with (I'm getting an error which I'm guessing it's due to API TF breakage).

CoderPat commented 5 years ago

I guess this issue is no longer relevant given #3 ? The requirements should be mostly solved by installing OpenGNN library.

bzz commented 5 years ago

Sorry for butting in and think you for maintaining and improving the code! I was wondering, is there is a reason not to include a requirement.txt?

CoderPat commented 5 years ago

It could be done, but the package depends on https://github.com/CoderPat/OpenGNN which isn't uploaded in pip, and since installing it would already install all the dependencies, I just though it would be redundant. However the addiction of the nltk dependecie might make it worth it to include it, will look into it.

On Fri, 12 Apr 2019, 00:01 Alexander, notifications@github.com wrote:

Sorry for butting in and think you for maintaining and improving the code! I was wondering, is there is a reason not to include a requirement.txt?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CoderPat/structured-neural-summarization/issues/2#issuecomment-482358295, or mute the thread https://github.com/notifications/unsubscribe-auth/AKurM1lQ3FuFYni0T0NZdkkRThnfDfG0ks5vf761gaJpZM4cl_ZQ .

ioana-blue commented 5 years ago

rouge is also required.