CoderPat / structured-neural-summarization

A repository with the code for the paper with the same title
MIT License
74 stars 26 forks source link

Bug in accounting for worse epochs #7

Closed ioana-blue closed 5 years ago

ioana-blue commented 5 years ago

This line of code: https://github.com/CoderPat/structured-neural-summarization/blob/master/train_and_eval.py#L289

should happen on an else branch. It's no big deal, but it's the equivalent of stopping one epoch early (or as if patience is one unit lower).