search

CoderanchCorral / Blackjack

Mozilla Public License 2.0
17 stars 2 forks source link

add shuffled deck function #15

Closed aquino-a closed 3 years ago

aquino-a commented 3 years ago

The changes are: -add function to get shuffled deck of cards. Blackjack requires the cards to be shuffled before dealing them. This PR will fulfill that requirement.

liutaurasvilda commented 3 years ago

One note: invest a bit more time writing PR description, in the way it is written currently, looks more like a draft.

I'm referring to this:

adds a function to get a shuffled stack of cards. uses existing getStandardDeck() to get the underlying cards. There is one test checking if all cards are present.

Perhaps we need to add a template for PR description structure. That would help having descriptions a bit more standardized.

nibsi commented 3 years ago

When you close your PR, please use "Squash and merge" and remove all individual commit messages that GitHub automatically adds to your PR description. Instead, write a new PR description that nicely summarizes the changes you've made to the code base and for what purpose.

aquino-a commented 3 years ago

When you close your PR, please use "Squash and merge" and remove all individual commit messages that GitHub automatically adds to your PR description. Instead, write a new PR description that nicely summarizes the changes you've made to the code base and for what purpose.

Is there something I should do for this PR other than update the description?

nibsi commented 3 years ago

@aquino-a when you click "Squash and merge", Github will first show you a new comment field where you can edit the title and description of the PR. You can leave the title as is. Modify the description to make it complete, but short and snappy.

Try it now. We trust you.

nibsi commented 3 years ago

Oh yeah, one more thing. After the PR has been merged, you still need to delete the branch. A button to delete your branch will appear right here, in this PR. Use it. :)

aquino-a commented 3 years ago

@aquino-a when you click "Squash and merge"

On this page I only see 'Close with comment'. Does 'squash and merge' after you select 'Merge pull request'? I'm not authorized to do that. When I close the PR, it doesn't show me 'Squash and merge', it only gives me an option to delete the branch.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

nibsi commented 3 years ago

When I close the PR, it doesn't show me 'Squash and merge'

I suppose only admins or owners can close pull requests.