CodersCare / gridelements

Be part of the future of TYPO3! Support Gridelements now and unlock exclusive early access to v13! The well-established Gridelements V12 elevates TYPO3 by bringing grid-based layouts to content elements, with powerful features like advanced drag & drop and real references. Supercharge your workflow and make daily tasks easier. Sponsor us here:
https://coders.care/for/crowdfunding/gridelements
GNU General Public License v3.0
5 stars 25 forks source link

Missing dependency to typo3/cms-setup #57

Open RozbehSharahi opened 1 year ago

RozbehSharahi commented 1 year ago

Hello,

as this package is setting user-settings on ext_tables.php it should have a dependency to typo3/cms-setup.

alternatively the whole setting of user-settings should be wrapped in an if statement checking if the extension is installed.

For instance following code throws an error, if typo3/cms-setup is not allowed:

$GLOBALS['TYPO3_USER_SETTINGS']['showitem'] .= ',
    --div--;LLL:EXT:gridelements/Resources/Private/Language/locallang_db.xlf:gridElements,
        dragAndDropHideNewElementWizardInfoOverlay,
        hideColumnHeaders,
        hideContentPreview,
        showGridInformation,
        disableDragInWizard,
        disableCopyFromPageButton
        ';

as it will be trying to concatenate on a string which is not defined $GLOBALS['TYPO3_USER_SETTINGS']['showitem'].