search

CodersCare / gridelements

Be part of the future of TYPO3! Support Gridelements now and unlock exclusive early access to v13! The well-established Gridelements V12 elevates TYPO3 by bringing grid-based layouts to content elements, with powerful features like advanced drag & drop and real references. Supercharge your workflow and make daily tasks easier. Sponsor us here:
https://coders.care/for/crowdfunding/gridelements
GNU General Public License v3.0
5 stars 25 forks source link

[BUGFIX] Call `getWorkspaceVersionOfRecord()` on TYPO3 >= v11 (#22) #70

Closed cundd closed 7 months ago

cundd commented 7 months ago

This fix will invoke getWorkspaceVersionOfRecord() instead of getMovePlaceholder() on TYPO3 version 11 and above.

I couldn't find any official deprecation information or migration information from TYPO3. To resolve this I followed the code updates from Flux (https://github.com/FluidTYPO3/flux/commit/94a832aad86391c1f88fa08583016e5573a94b16).

Bunnyfield commented 7 months ago

Thanks for your patch, but since there are dedicated versions for Gridelements and matchin TYPO3 version up to Gridelements 11.x and a combined version for CMS 11/12 starting with Gridelements 12, it does not make sense to distinguish between < 11 and >= 11.

So if you want this to be fixed in the dedicated 11 version please provide a patch the public 11-0 branch. In the upcoming version 12 for CMS 11/12 which is available in the early access repository, the change is already implemented.

cundd commented 7 months ago

Thank you for the clarification and sorry for the unneeded patch.

If a PR to 11-0 branch makes sense for you, I would love to create a new PR. Would you like me to create one?