CodersCrew / coderscamp

Monorepo containing CodersCamp's internal application, its website, and all development resources created around them.
https://www.coderscamp.edu.pl/
GNU General Public License v3.0
6 stars 3 forks source link

feat(api): [read | LearningMaterials] enhance CourseProgress read model with handling TaskWasCompleted #216 #244

Closed KrystianKjjk closed 3 years ago

KrystianKjjk commented 3 years ago

Closes #216

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

coderscamp-website – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-website/5HPVABjxe6XgYvo7NFVwQxZmwsaX
✅ Preview: https://coderscamp-website-git-issue-216-readlearning-88aba9-coderscamp.vercel.app

coderscamp-storybook – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-storybook/5ZU9khwyGJXBxG5kR83MjeMZdcC5
✅ Preview: https://coderscamp-storybook-git-issue-216-readlearni-745a53-coderscamp.vercel.app

coderscamp-docs – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-docs/5WDhsvxvHUtwpZA3vkQYA4Jm1ahN
✅ Preview: https://coderscamp-docs-git-issue-216-readlearningmat-72845e-coderscamp.vercel.app

codecov-commenter commented 3 years ago

Codecov Report

Merging #244 (40a1e36) into main (ceacc4b) will increase coverage by 0.82%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   82.78%   83.61%   +0.82%     
==========================================
  Files          88       92       +4     
  Lines         889      940      +51     
  Branches      130      135       +5     
==========================================
+ Hits          736      786      +50     
- Misses        152      153       +1     
  Partials        1        1              
Flag Coverage Δ
api 77.66% <100.00%> (+1.70%) :arrow_up:
ui 98.86% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/api/src/common/test-utils.ts 100.00% <100.00%> (ø)
...ead/course-progress/course-progress.read-module.ts 100.00% <100.00%> (ø)
...vent-repository/prisma-event-repository.service.ts 32.00% <0.00%> (-1.34%) :arrow_down:
packages/api/src/app.module.ts 100.00% <0.00%> (ø)
packages/ui/src/components/Label/Label.tsx 100.00% <0.00%> (ø)
...ckages/ui/src/components/HelperText/HelperText.tsx 100.00% <0.00%> (ø)
.../ui/src/components/MaterialsCard/MaterialsCard.tsx 100.00% <0.00%> (ø)
packages/api/src/courses/courses.module.ts 100.00% <0.00%> (ø)
packages/api/src/courses/courses.repository.ts 100.00% <0.00%> (ø)
packages/api/src/courses/courses.controller.ts 81.81% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ceacc4b...40a1e36. Read the comment docs.

MateuszNaKodach commented 3 years ago

We've merged PR with sample test for LearningMaterials Read model, so it'd be nice if you can also add similar to your code @KrystianKjjk :) And follow similar testing approach with next tasks.