Closed kacper-cyra closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/coderscamp/coderscamp-website/wSu41GLdvi3HoC8zfFUwoQaNLxRF
✅ Preview: https://coderscamp-website-git-issue-266-addcodecovba-c9bf20-coderscamp.vercel.app
🔍 Inspect: https://vercel.com/coderscamp/coderscamp-storybook/7myKYVA5nttzhF5kWKAfQY3Skfai
✅ Preview: https://coderscamp-storybook-git-issue-266-addcodecov-ed842e-coderscamp.vercel.app
🔍 Inspect: https://vercel.com/coderscamp/coderscamp-docs/3br7JUD4n9PuyV1VTkr5eE8hBV8J
✅ Preview: https://coderscamp-docs-git-issue-266-addcodecovbadge-2e585e-coderscamp.vercel.app
Merging #315 (8dfeaae) into main (743db2d) will decrease coverage by
0.18%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 87.34% 87.16% -0.19%
==========================================
Files 113 118 +5
Lines 1146 1309 +163
Branches 167 177 +10
==========================================
+ Hits 1001 1141 +140
- Misses 144 168 +24
+ Partials 1 0 -1
Flag | Coverage Δ | |
---|---|---|
api | 84.19% <ø> (+0.31%) |
:arrow_up: |
ui | 98.86% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...ure/event-repository/in-memory-event-repository.ts | 11.42% <0.00%> (-57.15%) |
:arrow_down: |
...ared/application/event-stream-name.value-object.ts | 47.36% <0.00%> (-10.53%) |
:arrow_down: |
packages/api/src/app.module.ts | 100.00% <0.00%> (ø) |
|
packages/api/src/shared/test-utils.ts | 100.00% <0.00%> (ø) |
|
...ead/course-progress/course-progress.read-module.ts | 100.00% <0.00%> (ø) |
|
...arning-materials/learning-materials.read-module.ts | 100.00% <0.00%> (ø) |
|
...terials-url-was-generated-event-handler.service.ts | 100.00% <0.00%> (ø) |
|
...ication/events-subscription/events-subscription.ts | 97.22% <0.00%> (ø) |
|
...events-subscription/events-subscription-builder.ts | 100.00% <0.00%> (ø) |
|
packages/api/src/shared/using.ts | 100.00% <0.00%> (ø) |
|
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 743db2d...8dfeaae. Read the comment docs.
@kacper-cyra Do you know if it's possible to have badge per package (api / ui / panel etc.) ?
@kacper-cyra Do you know if it's possible to have badge per package (api / ui / panel etc.) ?
I think it is. I will check it out.
@nowakprojects We can do it but we can't distinguish them from each other, so we could make a table like this repo: https://github.com/ethereumjs/ethereumjs-monorepo
@nowakprojects We can do it but we can't distinguish them from each other, so we could make a table like this repo: https://github.com/ethereumjs/ethereumjs-monorepo
For me it'd be awesome! :) Could you try to do something similar like in the repo?
So I added "tests" category and badges but these badges shows only workflow action status, so if we would like to take full advantage of them we would need to run tests for each package in separate workflow.
@KonradSzwarc c
So I added "tests" category and badges but these badges shows only workflow action status, so if we would like to take full advantage of them we would need to run tests for each package in separate workflow.
Thanks @kacper-cyra ! :) Right now we can leave it, in the future we will probably introduce separated workflows. @KonradSzwarc check out what do you think about it? I really like it :)
Closes #266