CodersCrew / coderscamp

Monorepo containing CodersCamp's internal application, its website, and all development resources created around them.
https://www.coderscamp.edu.pl/
GNU General Public License v3.0
6 stars 3 forks source link

feat(website): logo is not displayed in Navbar [Safari] #334 #339

Closed KrystianKjjk closed 3 years ago

KrystianKjjk commented 3 years ago

Closes #334

Modified Navbar a bit more than only logo, because in some cases, couldn't set width to 40px (depends on the screen logo had width between 34-40px)

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

coderscamp-website – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-website/GBR6wHGvKxwJsRGwSWZb7MJTsQyv
✅ Preview: https://coderscamp-website-git-issue-334-logoisnotdis-2c842d-coderscamp.vercel.app

coderscamp-storybook – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-storybook/B7Jer3H6oGp5gfiTW2ESumiWimvM
✅ Preview: https://coderscamp-storybook-git-issue-334-logoisnotd-e4ae35-coderscamp.vercel.app

coderscamp-docs – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-docs/J7m6MDCMYXm6xZK1WT5vVhojAJHY
✅ Preview: https://coderscamp-docs-git-issue-334-logoisnotdispla-770124-coderscamp.vercel.app

codecov-commenter commented 3 years ago

Codecov Report

Merging #339 (0a75672) into main (6bb6109) will decrease coverage by 1.51%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   87.28%   85.77%   -1.52%     
==========================================
  Files         121      121              
  Lines        1361     1371      +10     
  Branches      182      183       +1     
==========================================
- Hits         1188     1176      -12     
- Misses        173      195      +22     
Flag Coverage Δ
api 82.64% <ø> (-1.85%) :arrow_down:
ui 98.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...terials-url-was-generated-event-handler.service.ts 40.00% <0.00%> (-60.00%) :arrow_down:
...ackages/api/src/crud/courses/courses.repository.ts 57.14% <0.00%> (-42.86%) :arrow_down:
packages/api/src/crud/auth/auth-user.repository.ts 66.66% <0.00%> (-33.34%) :arrow_down:
packages/api/src/crud/auth/jwt/jwt.strategy.ts 50.00% <0.00%> (-16.67%) :arrow_down:
...terials-url/learning-materials-url.write-module.ts 91.66% <0.00%> (-8.34%) :arrow_down:
packages/api/src/crud/auth/local/local.strategy.ts 52.63% <0.00%> (-5.27%) :arrow_down:
...vent-repository/prisma-event-repository.service.ts 94.44% <0.00%> (-0.16%) :arrow_down:
packages/api/src/main.ts 0.00% <0.00%> (ø)
...ail-confirmation/email-confirmation.test-module.ts 100.00% <0.00%> (ø)
...ials-tasks/learning-materials-tasks.test-module.ts 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6bb6109...0a75672. Read the comment docs.