CodersCrew / coderscamp

Monorepo containing CodersCamp's internal application, its website, and all development resources created around them.
https://www.coderscamp.edu.pl/
GNU General Public License v3.0
6 stars 3 forks source link

fix(api): [EventsSubscription] should handle gaps in globalOrder #374 #375

Closed hkawalek closed 2 years ago

hkawalek commented 2 years ago

Closes #374

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

coderscamp-website – ./

πŸ” Inspect: https://vercel.com/coderscamp/coderscamp-website/4yvn2MkHHcJK1McKwFDtN5Ld8NyV
βœ… Preview: https://coderscamp-website-git-issue-374-eventssubscr-f1af55-coderscamp.vercel.app

coderscamp-storybook – ./

πŸ” Inspect: https://vercel.com/coderscamp/coderscamp-storybook/HyAFUsw1PCSBtiSuHk1JWwAzJf55
βœ… Preview: https://coderscamp-storybook-git-issue-374-eventssubs-6b5caa-coderscamp.vercel.app

coderscamp-docs – ./

πŸ” Inspect: https://vercel.com/coderscamp/coderscamp-docs/7FaZCgHUdvbUb4Bv8fs3nm1ufsSU
βœ… Preview: https://coderscamp-docs-git-issue-374-eventssubscript-e98bc0-coderscamp.vercel.app

codecov-commenter commented 2 years ago

Codecov Report

Merging #375 (ea97a3e) into main (e1801d7) will increase coverage by 0.14%. The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   88.43%   88.57%   +0.14%     
==========================================
  Files         150      151       +1     
  Lines        1773     1795      +22     
  Branches      232      236       +4     
==========================================
+ Hits         1568     1590      +22     
  Misses        204      204              
  Partials        1        1              
Flag Coverage Ξ”
api 86.44% <97.22%> (+0.20%) :arrow_up:
ui 99.01% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...ication/events-subscription/events-subscription.ts 93.39% <87.50%> (-0.30%) :arrow_down:
...bscription/events-subscription-position-pointer.ts 100.00% <100.00%> (ΓΈ)
packages/api/src/shared/test-utils.ts 98.02% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update e1801d7...ea97a3e. Read the comment docs.

hkawalek commented 2 years ago

I'm during review, but there are still some failing tests.

This PR was waiting for that PR. Now everything should work fine :smiley: