search

CodersOS / create

Website to create new iso images.
https://codersos.github.io/create
GNU Affero General Public License v3.0
1 stars 6 forks source link

Allow changing of the download file name #12

Open niccokunzmann opened 7 years ago

niccokunzmann commented 7 years ago

The downloaded file name can be changed. The path is

/download/<build-id>/<file-name>

Thus, we can safely allow the changing of the file name to be done in the web front end.

svasquez commented 7 years ago

Hi, how can I contribute?

niccokunzmann commented 7 years ago

Hi, if you like, you can solve this issue or choose any issue of your liking or create issues yourself and I help you solve them.

For this issue, you can change the last component of the download url - which is the file name. This can be done in installing.html, since this is where we can download the image. The idea: people may want to download the file with the date in the name or have it named after some purpose, like "programming-club-2017-02-17.iso".

What are your thoughts, @svasquez?

svasquez commented 7 years ago

Do you have some contribute guide? Because, I don't have experience with GitHub and pull request. But I want to learn.

niccokunzmann commented 7 years ago

Here is a list of git tutorials: https://github.com/fossasia/flappy-svg/tree/master/tasks/learn_git

You can also join the chat on FOSSASIA slack: http://fossasia-slack.herokuapp.com/ I am also @niccokunzmann there.

niccokunzmann commented 7 years ago

https://try.github.io/ is a nice git tutorial for all git commands. Knowing them is a nice addition to the desktop client. However, it does not cover pull-requests.

If you like to create your first pull-request, you can create a contributing.md. The idea behind the file is to guide new contributors to how to contribute to the project. You are perfectly fir to write down notes there. You can create the file like this:

  1. go to https://github.com/CodersOS/create
  2. click "create new file" and create the file contributing.md, write something and commit
  3. This leads you to the pull-request.
  4. You create a pull-request and I see it

When you created the pull-request, post the link here, so I can check back with you. If you have any troubles, you can post screenshots here or in the slack chat and we can help.

How would you like to go on, @svasquez?

svasquez commented 7 years ago

Thanks, @niccokunzmann for the info. I fork the repo, so I going to see the project to understand it. After, that, I will create the contributing.md and solve this issues.