search

CodersOS / create

Website to create new iso images.
https://codersos.github.io/create
GNU Affero General Public License v3.0
1 stars 6 forks source link

Github Logo not visible #20

Closed niccokunzmann closed 7 years ago

niccokunzmann commented 7 years ago

The logo of the link to the github page is not visible on the main website. Please make is visible.

Hint:

edsonmendieta commented 7 years ago

Hi nicco,

I edited the 'src' attribute to use a relative path for the github icon like so:

<span><img src="../assets/github_icon.png" style="height:20px" alt="">Visit our github!</span>

Is that what you wanted?

I made the change on my fork of the repository and it seems to be working just fine.

Here's a screen shot I took while running the site locally:

github-iconcreate

niccokunzmann commented 7 years ago

@edsonmendieta Yes, this is excatly what I wanted. Would you like to create a pull-request?

edsonmendieta commented 7 years ago

Great, will do.

niccokunzmann commented 7 years ago

Currently, I do not see the logo. We use jekyll includes: https://jekyllrb.com/docs/templates/#includes This means that _include is not the folder of the file. What are your thoughts, @edsonmendieta?

edsonmendieta commented 7 years ago

@niccokunzmann Sorry about that nicco, I didn't know that about the jekyll includes folder.

Removing the leading ".." so that the relative path is "assets/github_icon.png" seems to work just fine.

@mortaldraw has it in his pull request.

niccokunzmann commented 7 years ago

@mortaldraw @edsonmendieta Thanks! No problem, no harm. I am here to learn. I hope, you can learn things here, too. I hope you have no negative feelings about this. I am happy you are here, we have a conversation and fun and find out new things :)