Codess-Cafe / Codess-Website

The official website of Codess Cafe
https://codess.cafe/
11 stars 22 forks source link

Add counter effect to the "Numbers Speak Louder" Section #64

Closed coderbysoul closed 1 year ago

coderbysoul commented 1 year ago

The section currently looks like this--> image

I want to add a counter which counts up to the desired stats when a user sees the numbers(on page load). I have worked on this in my local in order to give a demo. Here is it:--

https://github.com/Codess-Cafe/Codess-Website/assets/96008596/51f6c38d-155f-4399-824c-1b6640ddad7d

Can I work on this issue?

VidhiBhatt01 commented 1 year ago

make this animation slightly slower

coderbysoul commented 1 year ago

make this animation slightly slower

https://github.com/Codess-Cafe/Codess-Website/assets/96008596/02d17cf5-9ad4-4ed2-aa1a-3d740a0063a2

Is this ok? Or should I make it slower

VidhiBhatt01 commented 1 year ago

perfect

VidhiBhatt01 commented 1 year ago

do git pull before raising PR

coderbysoul commented 1 year ago

do git pull before raising PR

Sure

VidhiBhatt01 commented 1 year ago

Seems like someone messed it up in their PR. Not sure how it went unnoticed by me during code review. Please add it again in the same PR. You can get your code from the merged PR

VidhiBhatt01 commented 1 year ago

https://github.com/Codess-Cafe/Codess-Website/commit/8562a504a301ecbb297b5a586e542d7cc747f3dc

identified the cause

coderbysoul commented 1 year ago

Seems like someone messed it up in their PR. Not sure how it went unnoticed by me during code review. Please add it again in the same PR. You can get your code from the merged PR

Should I add that missing code in the new pr which I will make for this issue? Or the old pr

VidhiBhatt01 commented 1 year ago

I fixed it, please pull again

coderbysoul commented 1 year ago

I fixed it, please pull again

I pulled, but saw that the animation is still not there, I checked that some other codes are also missing from that pr. Should I add them in this pr?

coderbysoul commented 1 year ago

image image These two were removed in https://github.com/Codess-Cafe/Codess-Website/commit/8562a504a301ecbb297b5a586e542d7cc747f3dc

VidhiBhatt01 commented 1 year ago

Yes please add them

coderbysoul commented 1 year ago

Yes please add them Done