CodethinkLabs / software-dependency-visualizer

Prototype software dependency visualizer tool
Apache License 2.0
0 stars 1 forks source link

Scrollbar doesn't always appear if there's a long list of packages #39

Open jmacarthur opened 8 years ago

jmacarthur commented 8 years ago

If there's lots of external packages and not many objects then the list of packages can go off the bottom of the screen and you don't get a scrollbar - it looks like the scrollbar only accounts for the height of the objects.

palvarez89 commented 8 years ago

We configure automatically the height of the svg depending on the number of rows of symbols in the objects columns. See https://github.com/CodethinkLabs/software-dependency-visualizer/blob/a6b39d66a9aabc719213581c6a7f4caa43430fb3/block-layout/src/index.ts#L824

We will have to include the number of packages in these columns to the equation to calculate the svg height to solve this problem, unless we can something more clever like "adjust to the contents" or similar (I don't know if that option exists)