Open panstromek opened 2 months ago
Hello @reslear and thank you and the community for this plugin.
I was wondering the same thing if you are going to release this version or if you need anything from us to test it and give you feedback.
Also one more thing. If you will release a new version with the Capacitor 6 support, since you are using semantic versioning maybe you can change the major number instead of the minor. Since it's a breaking change and not a new feature. So instead of 3.4.0 you can make it 4.0.0. Or if you want to follow the same logic as other capacitor plugin are doing, you can release it as 6.0.0 so that everyone can easily understand what version of Capacitor the current version is supporting.
Thank you in advance.
Hello, We are also experiencing this issue and it's critical for us. Currently Capacitor 5 + CodetrixStudio/CapacitorGoogleAuth 3.3.6 works fine But Capacitor 6 + CodetrixStudio/CapacitorGoogleAuth 3.4.0-rc.4 doesn't! Could you please fix it? Thanks!
FYI on Capacitor 6 this seems to work - remove the existing plugin and get the latest version direct from this github repo:
npm i github:CodetrixStudio/CapacitorGoogleAuth
Hopefully this will get released as eg 6.0.0 when ready.
Hello @chriscant,
For the environment
I'm getting error: ⚡️ To Native -> GoogleAuth signIn 113299101 CodetrixStudioCapacitorGoogleAuth/Plugin.swift:74: Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value
On Android it also doesn't work
FYI, We've decided to risk it and bumped to RC4, becuase we had to update everything else to capacitor 6.
Android seems to work for fine, but we got a report that it's not working on iOS. Haven't investigated it yet.
I reported the crash here: https://github.com/CodetrixStudio/CapacitorGoogleAuth/issues/387
I found out why: https://github.com/CodetrixStudio/CapacitorGoogleAuth/pull/269
basically, in the init function on Mobile the clientID is now used over the one you set in info.plist or others places.
This change hasn't been documented, of course.
Here is my change who make the plugin work like before:
In my case clientID is the one used for web only
I made a PR to explain this change: https://github.com/CodetrixStudio/CapacitorGoogleAuth/pull/390/files
My example on vue3 works with Capacitor 6 fine: https://github.com/belongnet/CapacitorGoogleAuth/tree/main/playground/vue3
This plugin is currently the last blocker for update to Capacitor 6 for us and it blocks some other important updates in our app.
Capacitor 6 support is released in some RC release, which I have hesitation to use out of caution, but I have trouble understanding what's the status of official final release. Is RC4 ready to be used, or should we keep waiting?
There are some problems reported for RC4 (e.g. https://github.com/CodetrixStudio/CapacitorGoogleAuth/issues/364), but I can't tell how critical they are for general use and if we should upgrade regardless or wait for fixes and final release.
Is there something specific you are waiting for with the release or is RC4 ready to be used? If not, is there something we can help with to push it forward?