Codeusa / Borderless-Gaming

Play your favorite games in a borderless window; no more time consuming alt-tabs.
GNU General Public License v2.0
5.5k stars 476 forks source link

[UI/Language] Newline characters (\r\n) appear in confirmation dialogs. #669

Closed Ephemeronic closed 6 months ago

Ephemeronic commented 6 months ago

Requirements

Summary

Newlines aren't being properly parsed from the language resources: the \r\n characters appear as normal text. image Issue exists in both master & net8. Apologies for not just committing a fix, but I'm relatively unfamiliar with Git/Github's processes / etiquette.

Steps to reproduce

  1. Be using en-US language
  2. Click Tools menu
  3. Click "Mouse Cursor Visibility"
  4. Notice that the formatting is a block of text with \r\n peppered throughout

Technical details

This can be resolved by checking for the newline characters in LanguageManager.Data() (either in an else block in the null/empty check, or after that if is closed): data = data.Replace(@"\r\n", Environment.NewLine);

image

version

10.0.0.0

andrewmd5 commented 6 months ago

This is fixed on Steam

PavloveVR commented 4 months ago

This is fixed on Steam

Can you link the commit? That type of fix is supposed to be mirrored here after 2 weeks. People are asking about that in #664