search

Codex- / await-local-workflow-run

✅ Await the completion of a local repository Workflow Run
MIT License
3 stars 0 forks source link

Allow other workflow to not even run #119

Open froblesmartin opened 1 year ago

froblesmartin commented 1 year ago

Hi @Codex- ! First of all, thanks a lot for publishing this action! I have been using the https://github.com/lewagon/wait-on-check-action action, but it does not allow the other workflow to not run at all (and it is not being maintained sadly)

I have been checking your code, and it seems it does not allow it either (or it will just take the last run from that workflow?)

JFYI, my use case is with OCI images and Helm charts. I store them in the same repository. So if I change a Helm chart, but not the code of the OCI images, I do not build the OCI images, and therefore I test the Helm charts with the OCI images from the version in the appVersion, and when there are changes in both, then I test the Helm chart with the OCI images built in that very same pull request, having to wait for them to be built before testing the Helm chart.

I guess this is a bit tricky. This action could have an input parameter allowing for not executed workflows, but then in the code, how do you consider if it is okay, or you should wait a bit more because it may have not started yet? 🤔

froblesmartin commented 1 year ago

I have workarounded it by using https://github.com/marketplace/actions/changed-files to check the same files as the path filters from the other workflow.

Codex- commented 1 year ago

After I created this action, a feature was introduced by github to allow you to just use another local workflow in your workflows which might be better suited overall

Take a look at these docs https://docs.github.com/en/actions/using-workflows/reusing-workflows#creating-a-reusable-workflow

I'm happy to add features to this action though if this action better suits your needs :)