Codigami / hapi-starter-kit

Hapi.js based REST boilerplate which uses latest ES7/ES8 features (async/await) with code coverage and follows best pratices
MIT License
109 stars 26 forks source link

Upgrade to v8 #1

Closed kunalkapadia closed 7 years ago

BadgerBadgerBadgerBadger commented 7 years ago

Suggestions:

kunalkapadia commented 7 years ago

@ScionOfBytes • What do you think about adding the debug package and making use of that? A. debug is generally recommended for libraries only, for application either winston or bunyan is used as they offer more features. In bunyan also you can set logLevel and do selective debugging. Let me know if you have more thoughts on this. Reference: https://blog.risingstack.com/node-js-logging-tutorial/

• In logger.js, we can reference the app name from the config instead of the package. A. Makes sense. Updated.

• .* in .dockerignore will cause the .eslintrc and .istanbul.yml to not be copied into the docker instance. Linting and testing wouldn't use these configs. A. Have updated .dockerignore to copy .eslintrc and .istanbul.yml