search

CodinGame / codingame-game-engine

CodinGame Engine
https://www.codingame.com
MIT License
112 stars 41 forks source link

Endscreen for > 2 players #19

Closed eulerscheZahl closed 5 years ago

eulerscheZahl commented 5 years ago

https://github.com/CodinGame/codingame-game-engine/blob/16fe1b4b9a3937ce0cbeb10376634e4979133320/engine/modules/endscreen/src/main/resources/view/endscreen-module/EndScreenModule.js#L174 There is no 3rd and 4th, only 1st and 2nd

https://github.com/CodinGame/codingame-game-engine/blob/16fe1b4b9a3937ce0cbeb10376634e4979133320/engine/modules/endscreen/src/main/resources/view/endscreen-module/EndScreenModule.js#L243-L244 If two players are 1st with the same score, the 3rd will be shows as 2nd

We already solved this issue for Code of Kutulu, see rankLetter and podium code.

NaejDoree commented 5 years ago

I made some fixes on the endscreen module which are here: https://github.com/CodinGame/codingame-game-engine/tree/endscreenmodule-more-than-2-players They should come with the next release ^^

CGjupoulton commented 5 years ago

Both fixes have been implemented