CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
214 stars 29 forks source link

Proposal: Use a different versioning scheme #291

Closed kaisalmen closed 5 months ago

kaisalmen commented 7 months ago

The current situation is: If you upgrade from 1.83.12 to 1.83.16 it seems like a patch, but it really isn't. 😅 If I use ~1.83.12 as a version selector in a dependent project you expect non-breaking changes. The only way to prevent this right now is to pin-point it to a fixed version like this: 1.83.12.

What do you think about the following version scheme? 185.0.0 = [vscode-version].[mva-level-changes].[mva-bugfixes]

So, new features, breaking changes will be 185.1.0, and bug fixes 185.0.1 like in regular semantic versioning. The meaning of minor is a bit stretched here, but there is at least the possibility to distinguish.

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 30 days with no activity.

CGNonofr commented 6 months ago

not stale!

CGNonofr commented 6 months ago

After some thinking, synchronizing the version with VSCode is an error... npm which uses semver is too restricting on version format and there is no ideal solution.

I see 2 issues with your suggestion:

So the solution is probably just to use semantic release and have a compatibility table somewhere (which can be automated)

What do you think?

kaisalmen commented 6 months ago

So the solution is probably just to use semantic release and have a compatibility table somewhere (which can be automated)

@CGNonofr If we want to rely on semantic versioning or let's say if dependent projects rely on it, there is no other way, I guess. 👍

github-actions[bot] commented 5 months ago

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: