CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
226 stars 31 forks source link

Chat + notebook + welcome service overrides #294

Closed CGNonofr closed 9 months ago

CGNonofr commented 10 months ago

based on https://github.com/CodinGame/monaco-vscode-api/pull/290

fix https://github.com/CodinGame/monaco-vscode-api/discussions/292

CompuIves commented 10 months ago

Hahaha I was meaning to contribute these extension points! Happy to see that you've already been working on this.

CGNonofr commented 9 months ago

Hahaha I was meaning to contribute these extension points! Happy to see that you've already been working on this.

Feel free to review it though (:

CGNonofr commented 9 months ago

Any change any of you have the time to have a look at it any time soon @kaisalmen @CompuIves ?

kaisalmen commented 9 months ago

@CGNonofr just build it locally and want to start looking at it in a bit

CGNonofr commented 9 months ago

Is it possible to test the new service overrides?

That's not easy!

I've just realized that some assets are missing the the welcome page, working ion it

CGNonofr commented 9 months ago

@kaisalmen I've just added 4 new commits

kaisalmen commented 9 months ago

@CGNonofr no more missing image at Help: Welcome. 👍

FYI; when you click on the "Get Started with VS Code for the Web" you see the following error in the console: image

Do you want/can fix that? Or is it for later?

CGNonofr commented 9 months ago

@CGNonofr no more missing image at Help: Welcome. 👍

FYI; when you click on the "Get Started with VS Code for the Web" you see the following error in the console: image

Do you want/can fix that? Or is it for later?

I don't know why those errors appear but I'm able to reproduce them on vscode.dev so I guess we won't be able to make them disapear

btw, 2 new commits for small fixes

kaisalmen commented 9 months ago

You need to update the package-lock.json of the demo. There is one change missing. Otherwise let's go

CGNonofr commented 9 months ago

package-lock updated!