search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
226 stars 31 forks source link

a few minor fixes #309

Closed CGNonofr closed 9 months ago

CGNonofr commented 9 months ago

A few minor fixes

The user data sync service override is not usable for the moment at it relies on a closed-source server hosted behing https://vscode-sync.trafficmanager.net/. But it may be useful in the future (see https://code.visualstudio.com/docs/editor/settings-sync#_can-i-use-a-different-backend-or-service-for-settings-sync)

The welcome walkthrough relies on a syncStatus context key to hide or display the suggestion to sync your data, and unfortunately, without the user data sync services, the context key remains undefined, while the condition is syncStatus != uninitialized, so the suggestion is displayed. The only way to hide it is ironically to register the user data sync service override without configuring any server

CGNonofr commented 9 months ago

You forgot to update the README with info about user-data-sync-service-override 😉

Oops! => d12dd55fd9b525fe2616389f17fd1866332642eb