search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
214 stars 29 forks source link

Cleanup and add missing service overrides #310

Closed CGNonofr closed 6 months ago

CGNonofr commented 6 months ago

I don't think there is any relevant service override left to implement :)

kaisalmen commented 6 months ago

@CGNonofr 🍾 I still need to test it

CGNonofr commented 6 months ago

Looking good! Next is update to vite 5 / rollup 4? 🤯

We are already using rollup 4, don't we?

kaisalmen commented 6 months ago

We are already using rollup 4, don't we?

Oh yes, nevermind! 😊 Then switching to vite 5 should be easy

CGNonofr commented 6 months ago

We are already using rollup 4, don't we?

Oh yes, nevermind! 😊 Then switching to vite 5 should be easy

I've already tried, there is a weird error about experimental decorator that looks blocking but is not (but still ugly). I was hoping them to fix it but it doesn't seem there is any change since then