search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
214 stars 29 forks source link

Fix extension contribution types #314

Closed CGNonofr closed 6 months ago

CGNonofr commented 6 months ago

IExtensionManifest type from vscode is wrong, i've fixed them in https://github.com/microsoft/vscode/pull/202360 and I've included the change in the patch here

also include Task service override (sorry @kaisalmen I was wrong, there were remaining ones :p)

fix #313

kaisalmen commented 6 months ago

IExtensionManifest type from vscode is wrong, i've fixed them in https://github.com/microsoft/vscode/pull/202360 and I've included the change in the patch here

Nice, did you see that the build pipeline failed in the PR?

kaisalmen commented 6 months ago

@CGNonofr Sie note: Are you aware the sourcemaps are broken? image

They are looking for <package>./src/... code. Is this fixable / a fix desired?

kaisalmen commented 6 months ago

@CGNonofr will you release 1.85.2 once this is merged?

CGNonofr commented 6 months ago

IExtensionManifest type from vscode is wrong, i've fixed them in microsoft/vscode#202360 and I've included the change in the patch here

Nice, did you see that the build pipeline failed in the PR?

Should be fine now

@CGNonofr Sie note: Are you aware the sourcemaps are broken? image

They are looking for <package>./src/... code. Is this fixable / a fix desired?

Yep, sourcemaps for this extension are broken on the VSCode side (they reference the sources while they are not bundled)

Vite should not even try to analyse those files though but I didn't find any way to prevent it from doing it

@CGNonofr will you release 1.85.2 once this is merged?

Sure