search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
226 stars 31 forks source link

Timeline view #317

Closed CGNonofr closed 8 months ago

CGNonofr commented 8 months ago

LGTM. Tested locally. Note: The package-lock.json is changed again when I do npm i in the demo. I use volta and it uses the correct npm version you specify. I don't know what is going on.

Ok I've understood... to have a clean package-lock, I remove the package-lock and node_modules then run npm i. And it seems running npm i a second time does change the package-lock (by adding the name field on every local dependencies)

fixed in last 2 commits

kaisalmen commented 8 months ago

@CGNonofr do you want to go the non-LTS node version on purpose? 20 is LTS 21 is current

CGNonofr commented 8 months ago

@CGNonofr do you want to go the non-LTS node version on purpose? 20 is LTS 21 is current

No really, is that a big deal? just trying to be as up to date as possible

kaisalmen commented 8 months ago

@CGNonofr is there no more automatic release?

CGNonofr commented 8 months ago

@CGNonofr is there no more automatic release?

Not anymore, it is manual so I can inject concise understandable changelog in the release

kaisalmen commented 8 months ago

When are you planning to publish the next one? I want to release a new monaco-languageclient version later this week and want to take the latest one aboard.