search

CodinGame / monaco-vscode-api

VSCode public API plugged on the monaco editor
MIT License
214 stars 29 forks source link

ExtensionHost now requires ExternalUriOpenerService.registerExternalOpenerProvider in 1.85.2 #319

Closed kevinvalk closed 6 months ago

kevinvalk commented 6 months ago

All was great in 1.85.1, but when I updated to 1.82.2 I got the following error. I am not 100% sure, but it seems this is only "implemented" in the RemoteAgent service https://github.com/CodinGame/monaco-vscode-api/compare/v1.85.1...v1.85.2#diff-a109a6740352f1fca73c8d93dd735b2907d78ceb6cfa491bd80617d4ad0594ae which I am not using.

The new base and host override services did not solve the issue either.

chunk-JER5SFHF.js?v=977b8117:89 Uncaught Error: unsupported

Error: unsupported
    at ExternalUriOpenerService.unsupported [as registerExternalOpenerProvider] (chunk-WCRHI5TI.js?v=977b8117:4696:9)
    at new MainThreadUriOpeners2 (chunk-FGF6K7P7.js?v=977b8117:28304:45)
    at _InstantiationService._createInstance (chunk-YLVE2GHV.js?v=977b8117:12674:20)
    at _InstantiationService.createInstance (chunk-YLVE2GHV.js?v=977b8117:12649:21)
    at ExtensionHostManager2._createExtensionHostCustomers (chunk-FGF6K7P7.js?v=977b8117:2557:53)
    at chunk-FGF6K7P7.js?v=977b8117:2431:19
    at chunk-JER5SFHF.js?v=977b8117:89:21
(anonymous) @ chunk-JER5SFHF.js?v=977b8117:89
setTimeout (async)
ErrorHandler.unexpectedErrorHandler @ chunk-JER5SFHF.js?v=977b8117:84
onUnexpectedError @ chunk-JER5SFHF.js?v=977b8117:116
onUnexpectedError @ chunk-JER5SFHF.js?v=977b8117:16
_createExtensionHostCustomers @ chunk-FGF6K7P7.js?v=977b8117:2563
(anonymous) @ chunk-FGF6K7P7.js?v=977b8117:2431
Promise.then (async)
ExtensionHostManager2 @ chunk-FGF6K7P7.js?v=977b8117:2423
_createInstance @ chunk-YLVE2GHV.js?v=977b8117:12674
createInstance @ chunk-YLVE2GHV.js?v=977b8117:12649
_doCreateExtensionHostManager @ chunk-FGF6K7P7.js?v=977b8117:4027
_createExtensionHostManager @ chunk-FGF6K7P7.js?v=977b8117:4008
_startExtensionHostsIfNecessary @ chunk-FGF6K7P7.js?v=977b8117:3997
_initialize @ chunk-FGF6K7P7.js?v=977b8117:3732
(anonymous) @ chunk-FGF6K7P7.js?v=977b8117:7932
Promise.then (async)
ExtensionService2 @ chunk-FGF6K7P7.js?v=977b8117:7930
ExtensionServiceOverride2 @ chunk-FGF6K7P7.js?v=977b8117:40139
_createInstance @ chunk-YLVE2GHV.js?v=977b8117:12674
_createServiceInstance @ chunk-YLVE2GHV.js?v=977b8117:12772
_createServiceInstanceWithOwner @ chunk-YLVE2GHV.js?v=977b8117:12763
_createAndCacheServiceInstance @ chunk-YLVE2GHV.js?v=977b8117:12753
_safeCreateAndCacheServiceInstance @ chunk-YLVE2GHV.js?v=977b8117:12711
_getOrCreateServiceInstance @ chunk-YLVE2GHV.js?v=977b8117:12699
get @ chunk-YLVE2GHV.js?v=977b8117:12628
(anonymous) @ vscode_localExtensionHost.js?v=977b8117:24649
(anonymous) @ chunk-RQAT3TQU.js?v=977b8117:61
(anonymous) @ chunk-RQAT3TQU.js?v=977b8117:61
invokeFunction @ chunk-YLVE2GHV.js?v=977b8117:12635
startup @ chunk-RQAT3TQU.js?v=977b8117:60
await in startup (async)
initialize2 @ chunk-WCRHI5TI.js?v=977b8117:12263
(anonymous) @ initialize.ts:115
Promise.then (async)
(anonymous) @ initialize.ts:114
Show 29 more frames
Show less
CGNonofr commented 6 months ago

Thanks for the report! It's hard to test every combinations. The fix is simple and coming soon.

In the meantime, you can add the remoteAgent service override

That's a shame you didn't report it 1 hour sooner though (: